fix(checkers): cover identity columns in column_value_at_risk + seque…#21
Merged
Conversation
…nce_drift
Both checkers filtered pg_depend.deptype = 'a', which only matches
SERIAL/bigserial and manual ALTER SEQUENCE ... OWNED BY. Identity
columns (GENERATED ... AS IDENTITY) use 'i' on PG10–11 and 'I' on PG12+,
so any team that migrated to identity columns — the modern recommended
replacement for SERIAL — was silently invisible to both rules.
Widen the filter to IN ('a', 'i', 'I'). Add positive tests for both
GENERATED BY DEFAULT and GENERATED ALWAYS in column_value_at_risk, and
a drift test for identity columns in sequence_drift; all run against
the full PG 10/13/15/17 matrix.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nce_drift
Both checkers filtered pg_depend.deptype = 'a', which only matches SERIAL/bigserial and manual ALTER SEQUENCE ... OWNED BY. Identity columns (GENERATED ... AS IDENTITY) use 'i' on PG10–11 and 'I' on PG12+, so any team that migrated to identity columns — the modern recommended replacement for SERIAL — was silently invisible to both rules.
Widen the filter to IN ('a', 'i', 'I'). Add positive tests for both GENERATED BY DEFAULT and GENERATED ALWAYS in column_value_at_risk, and a drift test for identity columns in sequence_drift; all run against the full PG 10/13/15/17 matrix.